Skip to content

Add MakerGo C3 SuperMini def #9050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 16, 2024
Merged

Add MakerGo C3 SuperMini def #9050

merged 5 commits into from
Jan 16, 2024

Conversation

DevZillion
Copy link
Contributor

Change Description

Adds support for the MakerGo ESP32 C3 SuperMini.

@CLAassistant
Copy link

CLAassistant commented Dec 29, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 29, 2023 •
edited
Loading

Warnings
⚠️

Some issues found for the commit messages in this PR:

  • the commit message "Add MakerGo C3 SuperMini def":
    • summary looks empty
    • type/action looks empty
  • the commit message "fix(makergo_c3_supermini): Remove pin definitions.":
    • body's lines must not be longer than 100 characters
    • summary should not end with a period (full stop)

Please fix these commit messages - here are some basic tips:

  • follow Conventional Commits style
  • correct format of commit message should be: <type/action>(<scope/component>): <summary>, for example fix(esp32): Fixed startup timeout issue
  • allowed types are: change,ci,docs,feat,fix,refactor,remove,revert,test
  • sufficiently descriptive message summary should be between 20 to 72 characters and start with upper case letter
  • avoid Jira references in commit messages (unavailable/irrelevant for our customers)

TIP: Install pre-commit hooks and run this check when committing (uses the Conventional Precommit Linter).
Messages
📖 You might consider squashing your 5 commits (simplifying branch history).

👋 Hello DevZillion, we appreciate your contribution to this project!

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- Addressing info messages (📖) is strongly recommended; they're less critical but valuable.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 9fc020a

@DevZillion DevZillion marked this pull request as draft December 29, 2023 23:11
@DevZillion DevZillion marked this pull request as ready for review December 29, 2023 23:20
P-R-O-C-H-Y
P-R-O-C-H-Y requested changes Jan 8, 2024
View reviewed changes
Copy link
Member

@P-R-O-C-H-Y P-R-O-C-H-Y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DevZillion PTAL on my comments.

@DevZillion
fix(makergo_c3_supermini): Remove pin definitions.
afd6fed 
Remove pin definitions since this part has been moved to the core and it defines globally per SoC & add an empty line at the end of the file.
@DevZillion DevZillion requested a review from P-R-O-C-H-Y January 8, 2024 19:47
@P-R-O-C-H-Y P-R-O-C-H-Y added the Status: Pending Merge Pull Request is ready to be merged label Jan 11, 2024
@me-no-dev me-no-dev merged commit 50f436c into espressif:master Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@P-R-O-C-H-Y P-R-O-C-H-Y P-R-O-C-H-Y approved these changes

Assignees
No one assigned
Labels
Status: Pending Merge Pull Request is ready to be merged Type: 3rd party Boards
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@DevZillion @CLAassistant @P-R-O-C-H-Y @me-no-dev @VojtechBartoska